Upgrading smartcontract #735
Conversation
|
Thank you so much! We'll get it reviewed and let you know if there are any questions or follow-ups! |
* remove unnecessary slash from a horizon redirect * reorder redirects for api references * fix redirects for hubble * fix some redirects for RPC
* fix nginx config. * Update storage language --------- Co-authored-by: overcat <[email protected]>
* fix nginx config. * Docs - Build Tab * Moving things around * moving some more things around * moving more things around * messing with tokens * moving and shuffling some files around * moving some more things from the most recent `main` commits * add a TODO about re-setting broken links configs * shifting around token things * update token interface to v20.5.0 * Adjustments * start on fixing the broken linkies * link extravaganza * links * links * content updates * content updates and formatting * homepage * redirects * fix some broken links in asset issuing tutorial * fix learn URL on index page * moving and shuffling build/token redirects * rename dapp frontend filename * adjusting/tweaking some older redirects * links * add a couple more redirect changes * specify the next/prev pagination items since we moved create frontend * /docs content * Moving assets and tokens * links * use mdx links in docs/README.mdx * misc fixes in stellar.toml info page * remove unnecessary heading in tokens quickstart page * shuffle and reorg sidebar declarations (no affect on actual docs) * expand smart contracts section in build sidebar * add some frontmatter config to docs/README.mdx * re-adding redirects that were overwritten --------- Co-authored-by: overcat <[email protected]> Co-authored-by: Elliot Voris <[email protected]>
* Add stellar wallet kit to developer tools * Add link to docs
* format, check * file name change * fix confusing file paths * added the complete script
* Data Introduction (draft) * Stellar RPC -> RPC
* fix nginx config. * Add descriptions to How-To Guide boxes * more descriptions --------- Co-authored-by: overcat <[email protected]>
* fix some broken, old links caught by the algolia crawler * re-generate specfile docs from changed files * broken link in anchor platform
|
Hi @ElliotFriend @briwylde08 , I have resolved the merge conflict and updated file folder structure. Updated File Path that I worked on : |
|
Thanks for fixing the conflicts! I'm guessing we'll get this reviewed next week. It's a holiday tomorrow in the US so most of the team has a short week. 🙏 |
|
@briwylde08 alright, looking forward to it. |
There was a problem hiding this comment.
Hi, there @KodeSage!! Looks really good! I left a few suggestions/changes throughout the file, and some of them are only nitpicks.
Thanks again!
|
Also, I don't know why Github is telling us that 243 files have been changed 🤣 I can see by comparing here that it's really only the one file. So... 🤷🏻♂️ |
|
Hi @ElliotFriend , I will definitely make up this changes and I push up soon. For the 243 files changed 😂, I have worked on this tasks before the changes you guys made in the codebase, so I had to pull all those changes in the branches I'm working on the different tasks assigned to me. |
|
HI @ElliotFriend , I made changes to the file you reviewed and I have pushed the updated format. please re-review. |
There was a problem hiding this comment.
Thanks for the changes, @KodeSage! I left a few more comments, almost entirely nitpicks. I think this is really close to ready!
|
I'm also noticing that this commit also includes the file from your other PR (#737). Can you remove it from here, so we don't end up with conflicting files? |
|
@ElliotFriend I will make changes to them now and push up in few minutes time. |
|
Hi @ElliotFriend , I made a push now with the updated changes please review. |
|
@KodeSage Looks good! Once the |
|
Thank you so much for your work here @KodeSage! I'll merge this and we can take the award conversation back to the corresponding issue. |
Bounty Submission for #626
Hello @briwylde08 This is ready for review